Skip to content

fix(inline-completion): potential inline completion failure due to input validation exception of supplemental context #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 19, 2025
Merged

fix(inline-completion): potential inline completion failure due to input validation exception of supplemental context #6758

merged 17 commits into from
Mar 19, 2025

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Mar 11, 2025 •
edited
Loading

Problem

ERROR: at 'supplementalContexts' failed to satisfy constraint: Member must have length less than or equal to 5

ERROR: supplementalContexts.1.member.content' failed to satisfy constraint: Member must have length less than or equal to 10240

Solution

Jebtrains PR aws/aws-toolkit-jetbrains#5466

 * Requirement
 * - Maximum 5 supplemental context.
 * - Each chunk can't exceed 10240 characters
 * - Sum of all chunks can't exceed 20480 characters
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): fix(inline-completion): potential inline completion failure due to input validation exception of supplemental context Mar 11, 2025
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review March 11, 2025 10:46
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners March 11, 2025 10:46
@Will-ShaoHua Will-ShaoHua marked this pull request as draft March 11, 2025 10:50
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review March 11, 2025 23:51
@Will-ShaoHua Will-ShaoHua mentioned this pull request Mar 11, 2025
Merged
@jpinkney-aws jpinkney-aws self-requested a review March 18, 2025 11:54
jpinkney-aws
jpinkney-aws reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests are failing for supplementalContextUtil truncation on windows

@Will-ShaoHua Will-ShaoHua enabled auto-merge (squash) March 19, 2025 03:38
@Will-ShaoHua Will-ShaoHua merged commit 070c36d into aws:master Mar 19, 2025
24 of 26 checks passed
@Will-ShaoHua Will-ShaoHua deleted the truncation branch March 19, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

@leigaol leigaol leigaol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Will-ShaoHua @leigaol @jpinkney-aws